[NFC] CtorEval fuzzing: skip export names that may need escaping#8502
Open
kripken wants to merge 1 commit intoWebAssembly:mainfrom
Open
[NFC] CtorEval fuzzing: skip export names that may need escaping#8502kripken wants to merge 1 commit intoWebAssembly:mainfrom
kripken wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Mar 20, 2026
| # Avoid names that need escaping. Just allow simple names like func_256, | ||
| # which the fuzzer emits | ||
| # TODO: fix escaping in the tool and here | ||
| func_exports = [export for export in func_exports if re.fullmatch(r'^\w+$', export)] |
Member
There was a problem hiding this comment.
I had to look up \w, and it's not clear that "Unicode word characters" is exactly the class we want. Let's be more explicit and use [a-zA-Z0-9_] instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzzing them is not that important for now.
Fixes #8482